Imgui support #288
Merged
Imgui support #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to test previous commit. Also added a panic in this commit
Git is forcing me to commit these changes so i can work on implementing the new stuff
Contributor
Author
|
14106 got released literally right after this PR lol, obviously offsets need updated for any tests |
Contributor
Author
|
Hey, just checking in with this PR. How are you doing so far on reviewing and fixing it? Is there anything I need to change or fix? |
Owner
|
Its been a couple busy weeks, i've added a reminder for this weekend to review it! |
Contributor
Author
|
Alright thanks! |
IMXNOOBX
merged commit 6612215
into
IMXNOOBX:hydrophobis-imgui-experimental
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opens with insert, closes with insert, can stay open to the side while you play, should be merged instead of #287 since it contains the same changes
Working on 14105:
